Digital Art Zone

Hi mac

I’m going through the script now, reformatting and adding comments which will hopefully help you. However, it doesn’t run on my system, because a number of the variables are undefined (e.g. g_oGUI). Is this the whole script, or was there something at the top (e.g. include(X) that you left out?

Thanks

Hi mac

I’ve gone through the script, reformatted to make it easier to read/understand and added comments to help. Haven’t changed any code, but I did add some comments marked *** where I thought the intent wasn’t clear.

maclean - 23 October 2012 04:07 AM

Well, I should have known it was too good to be true. This script is causing a new set of problems.

I had been testing the script with a basic door (in Room Creator), which is the slimmed-down version of the main door. Today I tried applying it to the main door, which has numerous other items parented to it - crossbars, dividers, etc - and discovered that when I apply the script, all items parented to the door move a considerable distance away. (That distance appears to be the exact reverse of the distance from the center of the scene - Ztrans -595).

So what I want to know now is, is there a way to ensure all parented items behave properly? I see various oChild references, but I don’t know what they mean. In this script, the final line reads
this.setProperties( oSkeleton, oChild, false );
whereas in my old 1.5 script, it reads
this.setProperties( oSkeleton, oChild, bRecurse );

I tried changing it to bRecurse, but with no luck. I’m almost ready to forget this and use the old v1.5 script which works perfectly.

Here’s my understanding of the script (some of these are assumptions because I don’t have the whole script):

1. You collect the selected nodes (including all their children if recurse is checked).
2. Then you run through all the collected nodes and if its name is “door” you move it and set its origin.
3. Then collect the selected surfaces and run through all of those.
4. If a surface has a material named hinge or hingback, you make it look pretty.

The this.setProperties( oSkeleton, oChild, false ) looks right to me, because if you’d checked recurse, its going to pick up all the children anyway when you collect selected nodes in #1, therefore no need to recurse again when setting the properties.

I also don’t think the script is causing the children to move away from the centre, because the script is ONLY touching a node named “door”. I wonder if DS is doing something to the children when the parent door moves. I’ll experiment with this and let you know - you using 4.5?

Edited the comment lines so that the page wasn’t running into the black border, rendering text unreadable.

Yes, parented items can behave oddly with rotation - I can’t recall when, or what the fix/work around is but I ssupect that’s the problem here, rather than anything in the script itself.

Ok. Hold everything, guys!! I’ve solved the issue. And in the dumbest way imaginable.

I was continuing updating the other scripts I have (there are hundreds of them!) and I came across one which changes switching geometry - ie - sets it to one of the alternatives. Of course, I hadn’t a clue how this would be written in DS 3, so I spent an hour going through the SDK docs and found nothing relating to alt geom (I never can find anything useful in those docs).

Anyway, to cut to the chase, on an impulse, I opened the old script in the IDE window, which of course, automatically updated it to DS 3 format. I then resaved and tested that script and it worked fine. I checked it in an editor and it all looked good, so I went back to the set origin script and did the same. Again, it updated, and again, it worked fine. (I haven’t tried these in DS 4.5 yet).

So, damn it all…. after all this dorking around, the solution was right there in DS 3. And as far as I can tell, the scripts work perfectly, with no issues whatsoever., and the parented parts on the door stay exactly where they’re supposed to.

Here’s what I have now. (From the begin function again).

DsActions.prototype.begin = function()
{
var bSelected = false;
var bRecurse = false;
var bRoot = false;
if( g_oGui.getNodes() == g_sSELECTED )
{
  bSelected = true;
}
if( g_oGui.getPropagation() == g_sRECURSIVE )
{
  bRecurse = true;
}
if( g_oGui.getNodes() == g_sROOT )
{
  bRoot = true;
  bSelected = true;
}
this.m_bMorphs = g_oGui.morphsChecked();
this.m_bLimits = g_oGui.limitsChecked();
this.m_bTransforms = g_oGui.transformsChecked();
this.m_bXRot = g_oGui.xRotChecked();
this.m_bYRot = g_oGui.yRotChecked();
this.m_bZRot = g_oGui.zRotChecked();
this.m_bXPos = g_oGui.xTranChecked();
this.m_bYPos = g_oGui.yTranChecked();
this.m_bZPos = g_oGui.zTranChecked();
this.m_bGScl = g_oGui.gScaleChecked();
this.m_bXScl = g_oGui.xScaleChecked();
this.m_bYScl = g_oGui.yScaleChecked();
this.m_bZScl = g_oGui.zScaleChecked();
setBusyCursor();
this.m_aNodes = this.collectNodes( bSelected, bRecurse, bRoot );
beginUndo();
for( var i = 0; i < this.m_aNodes.length; i++ )
{
  this.setProperties( this.m_aNodes[ i ].getSkeleton(), this.m_aNodes[ i ], bRecurse );
}
acceptUndo( String( “\”%1\”” ).arg( g_sSCRIPT_NAME ) );
clearBusyCursor();
}

/*********************************************************************/
DsActions.prototype.setNodeOrigin = function( xChange, yChange, zChange )
{
var movement = new DzVec3( xChange, yChange, zChange );
var curOrigin = this.m_oElement.getOrigin();
var bb = this.m_oElement.getLocalBoundingBox();
bb.translate( curOrigin );
newOrigin = bb.getCenter().add( movement );
if( curOrigin == newOrigin )
  return;
this.m_oElement.setOrigin( newOrigin );
movement = newOrigin.subtract( curOrigin );
var wsrot = this.m_oElement.getWSRot();
var wsscale = this.m_oElement.getWSScale();
var wspos = this.m_oElement.getWSPos();
wspos = wspos.subtract( movement );
movement = wsscale.multiply( wsrot.multVec( movement ) );
this.m_oElement.setWSPos( wspos.add( movement ) );
this.m_oElement.update();
}

/*********************************************************************/
DsActions.prototype.setProperties = function( oSkeleton, oNode, bRecurse )
{
var sSkeleton = “”;
if( oSkeleton )
{
  this.m_oSkeleton = oSkeleton;
  sSkeleton = this.m_oSkeleton.name;
}
this.m_oElement = oNode;
this.m_oObject = ( this.m_oElement ? this.m_oElement.getObject() : undefined );
switch( this.m_oElement.name )
{
  case “door”:
  this.setTransformProperty( “YRotate”, [ 0 ] );
  this.setNodeOrigin( 47.25, 0, -2.26 );
  this.setTransformProperty( “ZTranslate”, [ -3.5 ] );
  break;
  default:
  break;
}
if( bRecurse )
{
  var nNodes = oNode.getNumNodeChildren();
  var oChild;
  for( var n = 0; n < nNodes; n++ )
  {
  oChild = oNode.getNodeChild( n );
  if( oChild.inherits( “DzBone” ) )
  this.setProperties( oSkeleton, oChild, bRecurse );
  }
}
}
g_bCONTROL_PRESSED ? g_oGui.doDialog() : g_oGui.doNoDialog();

I really appreciate all the help, and I’m sorry for any wasted time.

cheers

mac

PS Cridgit - Check your PMs

I’m sure the dumbness/simplicity of the solution is directly proportional to the amount of time you’ve invested in looking for it!

That’s so funny, but no harm done. Just glad you got it working.

Cheers.

@Richard: by the way, code blocks and/or comments seems to cause havoc with the page formatting. You might want to ask the web team to look into this. Not only do the comments not wrap, but the page numbering and Prev/Next buttons don’t work properly on pages with code/comments.

Cheers

It also seems to be doing other weird things. This post is listed in New Posts as having 22 pages. I clicked on page 22 and arrived here, which is actually the top of page 3. But when I previously came to the thread from the Developer Forum page, cridgit’s post (above this one) was at the bottom of page 2.

Edit - After posting this, I arrived back at the bottom of page 2. LOL.

mac

Yes, this forum is till displaying posts instead of pages, and if you click on the last post link it puts it at the top of a page even if it would naturally fall part way down a page. Oh well, coders should be more robust than the average user or something.

Argh!

A quick question. Does anyone know if DS 4.5 saves switching geometry code in presets? I’ve tried the .duf types - Pose, Char - and they both seem to ignore it.

The resaved presets for switching geom don’t work in DS 4.5 (Surprise!), and neither do the original ones. I’m now trying to figure out what the code could possibly be. Or is it just broken? I know DS 4.5 has had issues with alt geom from the beginning.

mac

Is the geometry switching working on the figures? We found the other day that some very old items (Anton’s Victoria Changing Ponytail for example) was showing a drop-down list instead of a slider, and wasn’t applying materials or morphs to the alternative forms. A more recent item I made, on the other hand, is working tvia slider and is applying materials correctly. So it looks as if there may be subtle differences in how different items are handled.

Yes, everything works fine, but by dropdown menu - not a slider.

Bear in mind that all these figures are being opened from the Poser directory. One of the reasons for this Room Creator upgrade is to remove all .daz scenes and data so the user will only have a Poser install with .DSAs, plus the folders of DS presets (Materials & Poses, plus Toolbar). That’s why I’m opening everything from the Poser dirs.

So these are normal .cr2s and they all use menus for alt geom. What difference that makes, I don’t know, but it doesn’t seem like that’s the issue.

mac

Both of the items I was using were CR2s - there just seems to be a slight difference. However, when I checked I had the morphs from the base shape showing on all shapes which isn’t how it should work so even the one that was showing and responding to a slider wasn’t fully functional.

But is there any savable 4.5 preset which includes alt geom settings? I can’t find one.

I want to see what code it uses in the hope I can use it to update the ones I have.

mac

I can’t see a way to save the setting in a .duf file, but it worked in a .dsa preset. with both the Victoria Changing Ponytail (no slider) and my item (with slider).